[CALCITE-5787] The RelMdInputFieldsUsed is introduced to track the usage of input fields #4764
+212
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age of input fields
Member
Author
|
@julianhyde I have reimplemented this Jira according to your requirements. Please take a look when you have time. |
Member
Author
|
I have revised it according to the review comments in Jira. It would be great if someone could help review it. |
|
Member
Author
|
Since Julian has already reviewed this once, I've made the necessary changes and fixed the introduced bugs. If there are no further comments, I plan to merge this PR in 48 hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See CALCITE-5787
Given the previous misunderstanding, I revised the logic, changing the return value of the
getInputFieldsUsedmethod fromList<ImmutableBitSet>toImmutableBitSet. This change is somewhat blocking. I discussed it with @julianhyde on Jira, and considering that the previous PR was recently merged and hasn't been released yet, I think we can accept this change.The SemiJoinRule was also improved by using a new implementation.