[CALCITE-6504] JOIN_SUB_QUERY_TO_CORRELATE/Join SubQueryRemoveRule produces incorrect tree when using correlated sub-query in on clause of equi-join

[iwanttobepowerful]

CALCITE-6504

https://www.db-fiddle.com/f/uQcTTCm2orbi3sF7Eo7EMg/5

[NobiGo]

LGTM

[xiedeyantu]

I think you should use the same title as Jira. This way we can record this information effectively and mark Jira as resolved after the PR is merged.

[xuzifu666]

I think you should use the same title as Jira. This way we can record this information effectively and mark Jira as resolved after the PR is merged.

+1, but generally test PRs don't record Jira. Recording the associated Jira on the test cases should also OK.

[xiedeyantu]

It needs to be clarified that CALCITE-6504 is an existing unresolved PR. Theoretically, we should find which commit fixed the issue, but as discussed before, this isn't mandatory; confirming that the current issue is resolved is acceptable. Therefore, it's best to follow the usual rule of keeping the Jira title, commit message, and PR title consistent. This makes it easier to find the corresponding PR via a webpage. I believe this won't take much time.

[julianhyde]

In the commit message, bracket the case number, and follow the case number with the bug's description.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud