Skip to content

ATLAS-5195: Support to run ITs against postgres backend#505

Open
pinal-shah wants to merge 2 commits intomasterfrom
ATLAS-5195
Open

ATLAS-5195: Support to run ITs against postgres backend#505
pinal-shah wants to merge 2 commits intomasterfrom
ATLAS-5195

Conversation

@pinal-shah
Copy link
Collaborator

What changes were proposed in this pull request?

Add maven profile to execute below steps :-

  • Pull postgres image and run the docker
  • pre-intrgration-test phase, check if Atlas is up and running
  • lastly destroy container
    Currently CI build doesn't execute integration tests, it should run against both backend - hbase, postgres

How was this patch tested?


mvn ${ARG_PROFILES} ${ARG_SKIPTESTS} -DskipDocs clean package
#mvn ${ARG_PROFILES} ${ARG_SKIPTESTS} -DskipDocs clean package
mvn -Pit-rdbms -DskipUTs=true -DskipTests=false -DskipITs=false verify
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider controling the options (profile, skipUTs, skipITs) via .env file entries. Note that .env entries PROFILE and SKIPTESTS already exists; if necessary, introduce variables for SKIP_UT, SKIP_IT.

Please update README.md with details on choosing the backend (HBase or Postgres) while building Atlas using docker.

Is it possible to use RDBMS backend when building Atlas outside of docker?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants