ATLAS-5156: Import failure due to missing support for handling multip…#478
Open
sheetalshah1007 wants to merge 1 commit intoapache:masterfrom
Open
ATLAS-5156: Import failure due to missing support for handling multip…#478sheetalshah1007 wants to merge 1 commit intoapache:masterfrom
sheetalshah1007 wants to merge 1 commit intoapache:masterfrom
Conversation
89a8541 to
26fe29a
Compare
mandarambawane
approved these changes
Dec 8, 2025
0a4f7b3 to
75f6190
Compare
75f6190 to
af13a84
Compare
…le relationship types under a single attribute
af13a84 to
85e2798
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…le relationship types under a single attribute
What changes were proposed in this pull request?
Multiple relationship types handling in
EntityGraphMapperis refactored so that a single relationship attribute (likehive_db.tables) can safely support multiple relationshipDefs (e.g.hive_table_db, delta_table_db), choosing the appropriate relationship type per element instead of once for the whole attribute.The collection case now:
Groups related objects by their compatible relationship type via
groupElementsByRelationshipType.Maps each group with the correct
AtlasAttribute, logging and ignoring elements whose type doesn’t match any relationshipDefThe single-element case now:
Tries to find an appropriate relationship type; if none is found (e.g. Glossary term, invalid type), it logs and skips that value instead of failing or risking NPEs, preserving backward compatibility`.
How was this patch tested?
A dedicated test class,
EntityGraphMapperMultipleRelationshipTypesTest, is introduced to:hive_table/delta_tablecollections are correctly split and mapped.