Skip to content

Conversation

@jmao-denver
Copy link

@jmao-denver jmao-denver commented Jan 23, 2026

Rationale for this change

The bug breaks a Flight SQL server that refreshens the auth token when cookie authentication is enabled

What changes are included in this PR?

  1. In the ODBC layer, removed the code that adds a 2nd ClientCookieMiddlewareFactory in the client options (the 1st one is registered in BuildFlightClientOptions). This fixes the issue of the duplicate header cookie fields.
  2. In the flight client layer, uses the case-insensitive equality comparator instead of the case-insensitive less-than comparator for the cookies cache which is an unordered map. This fixes the issue of duplicate cookie keys.

Are these changes tested?

Manually on Windows, and CI

Are there any user-facing changes?

No

@jmao-denver jmao-denver requested a review from lidavidm as a code owner January 23, 2026 15:32
@github-actions
Copy link

⚠️ GitHub issue #48966 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting review Awaiting review label Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review Awaiting review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant