GH-48954: [C++] Add test for null-type dictionary sorting and clarify XXX comment #48955
+21
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Null-type dictionaries (e.g.,
dictionary(int8(), null())) are valid Arrow constructs supported from day one, but the sorting code had an uncertainXXX Should this support Type::NA?comment. We should explicitly support and test this because other functions already support this:I believe it does not make sense to specifically disallow this in dictionaries at this point.
What changes are included in this PR?
Added a unittest for null sorting behaviour.
Are these changes tested?
Yes, the unittest was added.
Are there any user-facing changes?
No.