Skip to content

Conversation

@lriggs
Copy link
Contributor

@lriggs lriggs commented Nov 18, 2025

Rationale for this change

The CPU attributes are not passed to the LLVM layer, which means potential optimizations could be missed leading to inefficient code. This feature was lost as part of the refactoring in 83cba25

I also discovered a bug with decimal alignments that was exposed by this change and was only reproducible in our test environment.

What changes are included in this PR?

Pass the CPU attributes to the LLVM code generation, and a unit test.
Fix the 16 bit vs 8 bit decimal alignment problem. This was causing a crash sometimes on certain architectures with certain queries. Added a unit test.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@github-actions
Copy link

⚠️ GitHub issue #48160 has been automatically assigned in GitHub to PR creator.

@thisisnic thisisnic changed the title GH-48160 Pass cpu attrs to LLVM GH-48160: [C++][Gandiva] Pass cpu attrs to LLVM Nov 18, 2025
@raulcd raulcd added the CI: Extra Run extra CI label Nov 20, 2025
@raulcd
Copy link
Member

raulcd commented Nov 20, 2025

@github-actions crossbow submit -g cpp

@github-actions
Copy link

Revision: 704804b

Submitted crossbow builds: ursacomputing/crossbow @ actions-2b90f7a897

Task Status
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions
example-cpp-tutorial GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-fedora-42-cpp GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-bundled GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-bundled-offline GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizer GitHub Actions

@kou kou changed the title GH-48160: [C++][Gandiva] Pass cpu attrs to LLVM GH-48160: [C++][Gandiva] Pass CPU attrs to LLVM Nov 23, 2025
@kou kou changed the title GH-48160: [C++][Gandiva] Pass CPU attrs to LLVM GH-48160: [C++][Gandiva] Pass CPU attributes to LLVM Nov 23, 2025
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants