Upload generated RST files after docs-build#39
Open
tremble wants to merge 1 commit intoansible-community:mainfrom
Open
Upload generated RST files after docs-build#39tremble wants to merge 1 commit intoansible-community:mainfrom
tremble wants to merge 1 commit intoansible-community:mainfrom
Conversation
briantist
reviewed
Apr 27, 2022
Collaborator
briantist
left a comment
briantist
left a comment
There was a problem hiding this comment.
This looks pretty good, thanks! I would like to do some tests. Right now we don't have tests for the shared workflows (#29) so they need to be tested in another repo, by referencing the PR branch version instead of the repo main version.
I will try to do that as soon as I can. Alternatively, you can change your collections' to point at your version, that would be helpful, and let you use your changes right away (can change back once merged).
What do you think about adding the same options to the push workflow too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the RST files are regenerated from modules the line numbers can be misleading. Upload a separate artefact bundle with the generated RST files.