fix(chips): Example violates axe accessibility tests #32679
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjshiu
added
dev-app preview
tjshiu
reviewed
Jan 20, 2026
Contributor
tjshiu
left a comment
tjshiu
left a comment
There was a problem hiding this comment.
So I like the change overall - but I do have a bit of a nit. The input is always on a new line here. Can we adjust it so that it isn't?
An alternative solution, but it would take more work: Add the role row and gridcell here and wrap the input. But I think it might not work because we wouldn't have the keyboard a11y for it (e.g. would still need to be able to arrow to the input). It would also pass the a11y checks but would be an issue for keyboard users since they are treated as separate tab stops.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28067