refactor: remove deprecated compiler option #32330
Open
+46
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
force-pushed
the
ts-6-base-url
branch
from
75d1ecd to
7d8ff76
Compare
Removes usages of the `baseUrl` compiler option which is deprecated and will start throwing an error in TypeScript 6.
crisbeto
force-pushed
the
ts-6-base-url
branch
from
7d8ff76 to
b578c52
Compare
crisbeto
commented
Jan 21, 2026
| }); | ||
|
|
||
| // TODO(crisbeto): the `baseUrl` here will trigger a deprecation error in TS6. We may | ||
| // have to opt out of it for this test since Webpack seems to depend on the `baseUrl`. |
Member
Author
There was a problem hiding this comment.
The context here is that it should work without the baseUrl since the default has been ./ for a while, but it doesn't for some reason. I suspect something in Webpack might be depending on it. Once TS6 is out, we can opt out these tests from the deprecation error.
crisbeto
added
action: review
alan-agius4
requested changes
Jan 21, 2026
Collaborator
alan-agius4
left a comment
alan-agius4
left a comment
There was a problem hiding this comment.
In general, this LGTM, though one of the test cases updates is incorrect.
| harness.expectFile(coveragePath).toNotExist(); | ||
| }); | ||
|
|
||
| it(`should collect coverage from paths in 'sourceRoot'`, async () => { |
Collaborator
There was a problem hiding this comment.
This changes the test. Coverage from node_modules is always ignored.
In this case, we want to ensure that coverage for local libraries is not included (IE: not included in node_module).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes usages of the
baseUrlcompiler option which is deprecated and will start throwing an error in TypeScript 6.