Skip to content

Fix syntax for Rsvg::Handle in test specs#401

Open
sparr wants to merge 1 commit intoandymeneely:devfrom
sparr:fix_tests_rsvg_handle
Open

Fix syntax for Rsvg::Handle in test specs#401
sparr wants to merge 1 commit intoandymeneely:devfrom
sparr:fix_tests_rsvg_handle

Conversation

@sparr
Copy link
Contributor

@sparr sparr commented Sep 3, 2025

Motivation

rake tests fail with a bunch of diffs like this:

@@ -252,7 +252,7 @@ cairo: scale([1.0, 1.0])
 cairo: rounded_rectangle([0, 0, 128.0, 128.0, 0, 0])
 cairo: clip([])
 cairo: translate([0, 0])
-cairo: render_rsvg_handle([Rsvg::Handlenil}])
+cairo: render_rsvg_handle([Rsvg::Handle, {id: nil}])
 cairo: restore([])
 cairo: save([])
 cairo: new_path([])

I'm not sure how those checks ever passed. The syntax is obviously wrong, including an unmatched }.

@sparr sparr force-pushed the fix_tests_rsvg_handle branch from f59e67b to 9f5206f Compare September 4, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant