Merged
Conversation
With the 2562b1a change to one shared login user it doesn't make as much sense to have individual per zone sudoers rules. Also, the rndc and knotc subcommands are narrow enough that I really don't see any real room for wildcard abuse. On the upside, this simplification takes away the need to rerun the _szh-sudoers_ command any time a zones gets added to the _zone-handler.yaml_ config file.
andreaso
force-pushed
the
simplify-sudoers
branch
from
9f41f57 to
435271f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the #56 change to one shared login user it doesn't make as much sense to have individual per zone sudoers rules. Also, the rndc and knotc subcommands are narrow enough that I really don't see any real room for wildcard abuse.
On the upside, this simplification takes away the need to rerun the szh-sudoers command any time a zones gets added to the zone-handler.yaml config file.