Move original units/constants and add updated ones#1132
Draft
rieder wants to merge 1 commit intoamusecode:mainfrom
Draft
Move original units/constants and add updated ones#1132rieder wants to merge 1 commit intoamusecode:mainfrom
rieder wants to merge 1 commit intoamusecode:mainfrom
Conversation
Member
Author
|
Not all units/constants have been updated yet, but the most important ones have. |
rieder
added
area: tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AMUSE units are outdated: in some cases they contradict international agreed values.
In this PR units and constants are updated to their current standards.
As a reference, the default values used in Astropy should be used.
Changes include:
yr is now the same as julianyr
au value is updated
solar/jupiter/earth related values updated
Make original AMUSE units / constants available under a new name
Update default AMUSE units / constants
Update tests
Test values of units against their Astropy equivalent
Make sure that Astropy unit names map one-to-one to AMUSE units (create aliases where needed, maybe deprecate old AMUSE names)