fix(invisible-text): make input wrapper styles customizable with inputContainer prop#44
fix(invisible-text): make input wrapper styles customizable with inputContainer prop#44Jeius wants to merge 1 commit intoamitpdev:mainfrom
Conversation
|
Did not really have time to go through this but just curious, what is the difference between the container style prop and the inputContainer style prop? Usually inputs like these are wrapped in one wrapper so I am trying to understand why there are container and inputContainer |
|
The Previously, inputContainer was unstyled, and the spinner and clear button were positioned absolute. That layout was causing the invisible text issue this PR is addressing. |
|
Thanks for the explanation, will have this tested in my app soon and I will report any issues. |
|
@R0EYK Thank you! |
Fixes #41
Description
This PR fixes the invisible text issue by improving the layout of the TextInput wrapper and making it customizable.
Changes
flexDirectiontorowfor proper horizontal alignment of input and controlsinputContainerstyle property toGooglePlacesTextInputStylesinterface, allowing users to customize the input wrapper stylinginputContainerstyle to the wrapper View component alongside the default stylesClearButtonAndSpinnercomponent conditionally renders either the loading indicator or the clear button, eliminating unnecessary whitespaceMotivation
Previously, the TextInput wrapper had limited styling options and the button/spinner layout was inefficient, which could cause text visibility issues and wasted space. This change:
inputContainerpropTesting
inputContainerstyles can now be applied through the style prop