Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
I don't think the wallet code is manageable right now as it is too complex and error-prone. It all needs to be switched to a useReducer to make any changes. |
atrefonas
suggested changes
Nov 18, 2022
Contributor
atrefonas
left a comment
atrefonas
left a comment
There was a problem hiding this comment.
All the wallet code needs to be changed to a useReducer. The hooks all need to be brought into algodex-react as well. The state changes need to happen in a single location. Otherwise too risky to make any changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ Overview
📝 Related Issues
🔐 Acceptance:
yarn testpasses