Fix memory leaks detected by running tests with AddressSanitizer#9
Open
maciej-pawlowski-opera wants to merge 3 commits intoadblockplus:masterfrom
Open
Fix memory leaks detected by running tests with AddressSanitizer#9maciej-pawlowski-opera wants to merge 3 commits intoadblockplus:masterfrom
maciej-pawlowski-opera wants to merge 3 commits intoadblockplus:masterfrom
Conversation
Contributor
|
Hello @maciej-pawlowski-opera, Thanks a lot for the contribution. We will process it, however we are currently restructuring our internal processes and therefore our reaction can be way too slow, despite the change might look pretty straightforward. I hope on your understanding. FYI, this github repository is basically a mirror of https://gitlab.com/eyeo/adblockplus/libadblockplus, where the main development is happening. So, the pull request (merge request) should be rather sent onto the gitlab repository. However I would recommend to wait for a confirmation from eyeo GmbH beforehand. |
Author
|
Sure thing, I'll recreate this fix on gitlab when I have a minute and I'll let you figure out how to process it whenever you see fit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two memory leaks were found when running tests built with asan.