Fix infinite recomposition when state properties used in composition#147
Open
kemalatli wants to merge 1 commit intoaclassen:mainfrom
Open
Fix infinite recomposition when state properties used in composition#147kemalatli wants to merge 1 commit intoaclassen:mainfrom
kemalatli wants to merge 1 commit intoaclassen:mainfrom
Conversation
…ggingItemTop` values are used in composition
|
I have cloned this PR into my own fork: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Infinite recomposition occurs when state properties such as
draggingItemTopanddraggingItemLeftare called within composition. Usecase would be to subscribe on these values viaLaunchedEffectto customize certain UI behavior like below.Steps to reproduce this bug is to add the above LaunchedEffect in the sample project. This PR addresses the issue by simply checking the
draggingItemKeyexistence. So that this value can only be fetched fromdraggingLayoutInfoonly if there is an acitve dragged item.Here is how hwui rendering looks like under infinite recomposition.
infinite-recomposition.mov