remove unmaintained click-plugins dependency#236
Open
sebix wants to merge 1 commit intoachillean:masterfrom
Open
remove unmaintained click-plugins dependency#236sebix wants to merge 1 commit intoachillean:masterfrom
sebix wants to merge 1 commit intoachillean:masterfrom
Conversation
click-plugins is unmaintained for 6 years and incompatible with current click 6.2.0 (click-contrib/click-plugins#38) click-plugins is not required to run shodan-python, only adds a possibility for third parties to potentially hook into the cli interface. if that's required, it needs to be done by other means keeping the dependency to an unmaintained library is also a potential security risk and prevents the usage of current versions of click itself
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
click-plugins is unmaintained for 6 years and incompatible with current click 6.2.0 (click-contrib/click-plugins#38)
click-plugins is not required to run shodan-python, only adds a possibility for third parties to potentially hook into the cli interface. if that's required, it needs to be done by other means
keeping the dependency to an unmaintained library is also a potential security risk and prevents the usage of current versions of click itself