feat: manipulate ConsoleLog events on app's side#83
Open
juniorklawa wants to merge 6 commits intoabner:masterfrom
Open
feat: manipulate ConsoleLog events on app's side#83juniorklawa wants to merge 6 commits intoabner:masterfrom
juniorklawa wants to merge 6 commits intoabner:masterfrom
Conversation
feat: added support to multiple params on console log
…console feat: added option to disabled terminal console
|
This will be handled in an upcoming release of mercury, openwebf/mercury#24 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I've added the possibility to handle ConsoleLog events on the app's side, not only on the library's side.
Imagine a scenario where I need to store console.log output on a variable for example, with the actual implementation I can't because the output of console.log events is only accessible on the library's side.
So this code:
Will have this output:
Because this is how flutter_js is dealing with console events:
With my implementation (setting useFlutterTerminal to false) is now possible to choose if you want the console events to be handled by the library or app side
Like this:
Giving this output:
I am not so sure if
useFlutterTerminalis the best name for it, I am accepting suggestions @abnerThanks!