-
Notifications
You must be signed in to change notification settings - Fork 110
feat!: Update a2a.proto d14f410 #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @jmesnil, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refining the API by renaming a key method for push notification configuration to improve clarity and consistency with common API patterns. Additionally, it streamlines the agent capabilities by removing a deprecated feature, leading to a cleaner and more focused design. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request successfully updates the method name from setTaskPushNotificationConfig to createTaskPushNotificationConfig across the codebase, reflecting a more accurate semantic meaning for the operation. The removal of the stateTransitionHistory capability is also consistently applied throughout the relevant files, including the protobuf definition where the field number is correctly reserved. The changes are well-propagated across client, server, and test modules, ensuring consistency. The cleanup of unused imports in JSONRPCTransportTest.java is also a good improvement for maintainability.
client/transport/spi/src/main/java/io/a2a/client/transport/spi/ClientTransport.java
Outdated
Show resolved
Hide resolved
based on a2aproject/A2A@d14f410 Signed-off-by: Jeff Mesnil <jmesnil@ibm.com>
4df3354 to
f75abcf
Compare
based on a2aproject/A2A@d14f410