Skip to content

Conversation

@jmesnil
Copy link
Collaborator

@jmesnil jmesnil commented Jan 26, 2026

@jmesnil jmesnil requested a review from kabir January 26, 2026 17:30
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jmesnil, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the API by renaming a key method for push notification configuration to improve clarity and consistency with common API patterns. Additionally, it streamlines the agent capabilities by removing a deprecated feature, leading to a cleaner and more focused design.

Highlights

  • Method Renaming: The setTaskPushNotificationConfiguration method across various client, transport, and server components has been renamed to createTaskPushNotificationConfiguration to better reflect its behavior as a creation or update operation, aligning with standard API design principles.
  • Removal of stateTransitionHistory Capability: The stateTransitionHistory capability has been removed from AgentCapabilities across the codebase, including its definition in a2a.proto, Java models, and related tests and examples. This simplifies the agent's declared capabilities.
  • JSON-RPC Wrapper and gRPC Definition Updates: Corresponding JSON-RPC request/response wrappers (SetTaskPushNotificationConfigRequest/Response) and gRPC definitions have been renamed to CreateTaskPushNotificationConfigRequest/Response to match the new method naming, ensuring consistency across the protocol layers.
  • Code Example and Test Updates: All relevant code examples in README.md and numerous unit/integration tests have been updated to use the new method names and reflect the removal of the stateTransitionHistory capability, ensuring correctness and maintainability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully updates the method name from setTaskPushNotificationConfig to createTaskPushNotificationConfig across the codebase, reflecting a more accurate semantic meaning for the operation. The removal of the stateTransitionHistory capability is also consistently applied throughout the relevant files, including the protobuf definition where the field number is correctly reserved. The changes are well-propagated across client, server, and test modules, ensuring consistency. The cleanup of unused imports in JSONRPCTransportTest.java is also a good improvement for maintainability.

based on a2aproject/A2A@d14f410

Signed-off-by: Jeff Mesnil <jmesnil@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant