Skip to content

Conversation

@ehsavoie
Copy link
Collaborator

If the tenant is not defined in the JSONRPC payload, we use the one from the request path.

Fixes #612 🦕

If the tenant is not defined in the jsonrpc payload, we use the one from
the request path.

Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
@ehsavoie ehsavoie requested review from jmesnil and kabir and removed request for jmesnil January 26, 2026 16:54
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ehsavoie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the application's multi-tenancy capabilities by introducing a robust mechanism to manage tenant identification within JSONRPC requests. It ensures that if a tenant is not explicitly provided in the JSONRPC payload, it is automatically derived from the incoming request's URL path. This change streamlines tenant context propagation, making the system more resilient and consistent in handling tenant-specific operations.

Highlights

  • Tenant Extraction from Request Path: Implemented logic to extract tenant information directly from the request path if it's not provided in the JSONRPC payload.
  • JSONRPC Request Parsing Update: Modified the JSONRPCUtils.parseRequestBody method to accept and utilize the extracted tenant, ensuring it's set in the corresponding request builders.
  • Context Key Introduction: Introduced TENANT_KEY constants in both JSONRPC and REST context key classes to store the tenant identifier.
  • Comprehensive Test Coverage: Added new unit tests to A2AServerRoutesTest to validate tenant extraction across various URL path structures (root, single-segment, multi-segment) and updated existing tests in JSONRPCUtilsTest to accommodate the new tenant parameter.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully implements the feature of managing tenant information in both JSONRPC and REST requests. The extractTenant methods correctly derive the tenant from the request path, and the JSONRPCUtils.parseRequestBody method intelligently applies this tenant information only if it's not already present in the JSONRPC payload. The added test cases in A2AServerRoutesTest.java provide good coverage for the tenant extraction logic, covering various path scenarios. The changes are well-contained and effectively address the stated objective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: JSONRPC doesn't get the tenant from the request path

1 participant