Conversation
| */ | ||
| "AzureAd": { | ||
| "Instance": "https://login.microsoftonline.com/", | ||
| "Domain": "commerce.zunes.me", |
There was a problem hiding this comment.
Looks like I missed one.
| Member member = ctx.Members.First(m => m.ZuneTag == zuneTag); | ||
| if (member == null) | ||
| return StatusCode(StatusCodes.Status400BadRequest, $"User {zuneTag} does not exist."); | ||
| // using var ctx = new ZuneNetContext(); |
There was a problem hiding this comment.
This does not compile right now. Do you have a branch where it does, that I should rebase against?
There was a problem hiding this comment.
Nope, I just haven't touched messaging in a long time. Don't worry about it
Zune.DB.Console/Program.cs
Outdated
| { | ||
| // Set up CLI options | ||
| string connectionString = "mongodb://localhost:27017"; | ||
| string connectionString = "mongodb://mongo:27017"; |
There was a problem hiding this comment.
This should be pulled into IConfiguration so that it can be one of many configuration types including environment variables.
| { | ||
| "ZuneNetContext": { | ||
| "ConnectionString": "mongodb://localhost:27017", | ||
| "ConnectionString": "mongodb://mongo:27017", |
There was a problem hiding this comment.
In docker, you can expose things like connection strings to a running container as an environment variables. I'm gonna probably revert this to localhost and define the runtime connection strings in docker-compose.yml
| WORKDIR /source | ||
|
|
||
| # copy csproj and restore as distinct layers | ||
| COPY ./ . |
There was a problem hiding this comment.
Ideally this should be broken into layers of dependency. I need to research the right way to do this for a .net project like this.
| version: '3.4' | ||
|
|
||
| services: | ||
| mongodb: |
There was a problem hiding this comment.
Probably need to see if this can start and finish booting before the rest of the containers start
…to recover your own SID from the POST and add it to your profile to use it though.
… availble in all build targets.
also Parallel.ForEachAsync is cool. also albumart sort of loads
…someday, ill add the restart policy
…same resizing routines for the v3.2 endpoints
…en the tracking gif is missing by adding one.
- actual image resizing - MIX should now be returning something sensible
2 participants
I still need to hook up all the networking, but
docker compose build(implementing your constants, obviously) builds, anddocker compose upstarts all the services.