-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Enhance error handling for composer update in env:start
#9360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Enhance error handling for composer update in env:start
#9360
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Seems there's a left-over orphan Docker container when the Composer update fails. Maybe it can be removed at the end there? |
…ment - Adds `--rm` flag to automatically remove containers after composer update completes, preventing orphaned containers - Updates error message to "There was an error while running PHP Composer update" for clarity, distinguishing it from Docker Compose commands
Thank you for the feedback! I've updated the PR to address both concerns |
azaozz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good imho.
This PR improves the developer experience for
npm run env:startby providing clear, actionable error messages ifcomposer updatefails.Trac ticket: https://core.trac.wordpress.org/ticket/62807
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.