Fix --dump-test-list #266
Open
Fix --dump-test-list #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
As a follow-up I should still implement a proper cli tests that parses the output for --dump-test-list and --help |
danleh
approved these changes
Jan 20, 2026
Contributor
danleh
left a comment
danleh
left a comment
There was a problem hiding this comment.
LGTM with question / optional rejection of the startsWith('--no') change.
| } | ||
| let value = parts.slice(1).join("="); | ||
| if (flagName === "no-prefetch") value = "false"; | ||
| if (flagName.startsWith("no-")) value = "false"; |
Contributor
There was a problem hiding this comment.
Do we have some other parameter that uses this --no prefix? Or rather: all other boolean parameters are set to false by default, whereas prefetchResources is true, right? So maybe don't generify this just yet, since supplying, e.g., --no-ramification does nothing, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We moved the params parsing partially to the Params which was not use in cli.js
Directly use the cli-only arguments in cli.js instead.