Add depot-tools meant for chromium development#2
Merged
FrederickEngelhardt merged 7 commits intomainfrom Dec 30, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for installing and initializing depot_tools, a set of utilities required for Chromium development. The implementation registers depot_tools as a new optional component that can be enabled/disabled through configuration files. However, the PR also includes two unrelated utility installation scripts (tree and cmake) and removes a user-specific path from source control.
- Adds depot_tools component with installation script and shell initialization
- Updates all configuration YAML files to include the new depot_tools option
- Modifies CLI to register and handle depot_tools component installation
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| src/zsh/snippets | Removes accidentally committed file containing hardcoded user path |
| src/zsh/plugin-init/depot-tools.zsh | Adds shell initialization for depot_tools PATH setup (but not integrated into base.zsh) |
| src/setup/install-depot-tools.zsh | Implements depot_tools installation/update script |
| src/setup/install-tree.zsh | Unrelated: adds tree utility installer (missing shebang, not registered) |
| src/setup/install-cmake.zsh | Unrelated: adds cmake installer (missing shebang, not registered) |
| osa-cli.zsh | Registers depot-tools component and adds to component_keys arrays |
| configs/*.yaml | Adds depot_tools flag to all configuration presets |
Comments suppressed due to low confidence (1)
src/zsh/snippets:1
- This file should not be tracked in git. According to .gitignore line 10, the entire src/zsh/snippets/ directory is intentionally ignored because it contains downloaded snippets installed during setup. This file appears to contain a hardcoded user-specific path (/Users/fre/dev/osa-snippets) which should never be committed. The deletion is correct, but verify this wasn't accidentally committed in a previous change.
| @@ -0,0 +1,3 @@ | |||
| # Install cmake for building C/C++ projects | |||
There was a problem hiding this comment.
Missing shebang at the beginning of the file. All zsh script files must start with #!/usr/bin/env zsh according to the project's coding guidelines.
…understanding as chromium cannot/is not supported for building on macos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: depot tools for chromium
title: ''
labels: ''
assignees: ''
Description
Type of Change
Release Management
For automatic release on merge, add one of these labels:
release:major- Breaking changes, incompatible API changes (bumps 1.x.x → 2.0.0)release:minor- New features, backwards-compatible (bumps x.1.x → x.2.0)No label = No automatic release (manual release via GitHub Actions later)
Testing
./osa-cli.zsh --scan-secrets(if touching constructors)./tests/run-tests.zshChecklist
#!/usr/bin/env zshshebang to new scriptsosa-secret-setinstead).zshextension (unless intentionally.shfor bash)release:majororrelease:minor)Additional Context