Mouse usability and vim navigation keys#1
Open
elig0n wants to merge 3 commits intoVideoPlayerCode:masterfrom
Open
Mouse usability and vim navigation keys#1elig0n wants to merge 3 commits intoVideoPlayerCode:masterfrom
elig0n wants to merge 3 commits intoVideoPlayerCode:masterfrom
Conversation
as they overwrite the multi-key defaults in SelectionMenu.js
Mouse wheel up & down to scroll list one by one and left mouse button to select. Keyboard 'j' & 'k' for up one and down one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more a hack for a PR I would open an Issue for it first if it was possible
The issue: Adding multiple keyRebindings as an array is impossible, but I managed it with commenting out keyRebindings completely and setting multi keys as the default keyBindings in SelectionMenu.js. Using the mouse along with the keyboard (and vi movement keys) for selection is only what I wanted so this gets this for me but implementing multikey keyRebindings as a general functionality would be better.