Skip to content

Conversation

@YuurinBee
Copy link

Android displayed a small circular icon inside of the square or rounded square app icon parameters. These changes should update it to be more responsive. Reference image below for what it currently looks like before this commit. Needs testing and compiling on Android.

image

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Claude finished @YuurinBee's task in 1m 37s —— View job


PR Review: Android App Icon Fixes

  • Read CLAUDE.md for repository guidelines (no CLAUDE.md found)
  • Review the changed files
  • Check the Android icon implementation
  • Provide feedback

Summary

This PR addresses the Android app icon display issue where the icon was appearing as a small circle inside the launcher shape. The changes include:

  1. Background XML simplified (ic_launcher_background.xml): Replaced a complex 170-line vector drawable (containing a grid pattern) with a simple solid color shape (#030303 - near black)
  2. Foreground PNGs updated: New foreground images with the Vector logo properly sized for each density bucket (48-68% size reduction across all densities)

Analysis

Issue Identified: The screenshot shows the Vector icon appearing very small within a circular container, while other app icons fill their containers appropriately. This happens when the foreground drawable isn't properly sized for the adaptive icon safe zone (centered in a 108dp canvas with 72dp content area).

Changes Made:

  • The new foreground PNG shows a properly-sized Vector logo that should fill more of the visible area
  • The background was simplified from a debug grid pattern to a solid dark color

Concerns

1. Missing Adaptive Icon Configuration

The Android project is missing mipmap-anydpi-v26/ic_launcher.xml and mipmap-anydpi-v26/ic_launcher_round.xml files, which are required for properly configuring adaptive icons on Android 8.0+. Without these, Android falls back to legacy icon handling.

A proper adaptive icon setup should include:

<adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android">
    <background android:drawable="@drawable/ic_launcher_background"/>
    <foreground android:drawable="@mipmap/ic_launcher_foreground"/>
</adaptive-icon>

2. Conflicting Foreground Assets

There's a drawable-v24/ic_launcher_foreground.xml file containing the Android robot logo (not the Vector logo), which may conflict with the PNG foreground assets. This XML foreground appears to be leftover from an Android project template.

3. Missing Newline at EOF

The ic_launcher_background.xml file is missing a trailing newline (minor style issue).

Recommendations

  1. Add adaptive icon XML files in mipmap-anydpi-v26/ directory to properly declare the adaptive icon layers

  2. Remove or update drawable-v24/ic_launcher_foreground.xml which contains the default Android robot icon, not the Vector app logo

  3. Test on multiple launchers - different Android launchers handle icons differently (square, rounded square, squircle, circle, etc.)

Verdict

The core fix (properly sized foreground PNGs and solid background) should address the immediate issue. However, to ensure consistent icon display across all Android 8.0+ devices, I recommend adding the adaptive icon XML configuration files before merging.

Overall: The approach is correct for fixing the icon size issue, but the implementation is incomplete without the adaptive icon XML files.


@YuurinBee YuurinBee closed this Feb 3, 2026
@YuurinBee YuurinBee deleted the android-app-icon branch February 3, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants