-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove unused files, drop prettier, fix biome issues #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
juniorbutyeah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 16 out of 19 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }); | ||
| }, | ||
| ); | ||
| //# sourceMappingURL=scramjet.sync.js.map |
Copilot
AI
Jan 30, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be a generated/minified file (evidenced by the source map comment and the single-line format in the original). Generated files are typically excluded from formatting tools and should be regenerated from source rather than manually formatted. While biome exclusions have been added for public/assets in this PR, this file has already been formatted. Consider whether this file should be regenerated from its source instead, or if it should remain in its original minified form.
| //# sourceMappingURL=scramjet.sync.js.map | |
| // Source map: scramjet.sync.js.map |
| } | ||
| for (; o < e.length; ) { | ||
| for (t = o, a = !1; l(); ) | ||
| if ("," === (r = e.charAt(o))) { |
Copilot
AI
Jan 30, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value assigned to r here is unused.
| return (t = (t = new String(t).toString()).replace(/url\(['"]?(.+?)['"]?\)/gm, (t, i) => { | ||
| const a = "rewrite" === e ? (0, n.Oy)(i.trim(), r) : (0, n.v2)(i.trim()); | ||
| return t.replace(i, a); | ||
| })).replace(/@import\s+(url\s*?\(.{0,9999}?\)|['"].{0,9999}?['"]|.{0,9999}?)($|\s|;)/gm, (t, i) => |
Copilot
AI
Jan 30, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value assigned to t here is unused.
| return s("unrewrite", e); | ||
| } | ||
| function s(e, t, r) { | ||
| return (t = (t = new String(t).toString()).replace(/url\(['"]?(.+?)['"]?\)/gm, (t, i) => { |
Copilot
AI
Jan 30, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value assigned to t here is unused.
| r(8866), ((i = n || (n = {}))[(i.DISCONNECTED = 1)] = "DISCONNECTED"), (i[(i.PRECEDING = 2)] = "PRECEDING"), (i[(i.FOLLOWING = 4)] = "FOLLOWING"), (i[(i.CONTAINS = 8)] = "CONTAINS"), (i[(i.CONTAINED_BY = 16)] = "CONTAINED_BY"); |
Copilot
AI
Jan 30, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value assigned to n here is unused.
| var n, i; | |
| r(8866), ((i = n || (n = {}))[(i.DISCONNECTED = 1)] = "DISCONNECTED"), (i[(i.PRECEDING = 2)] = "PRECEDING"), (i[(i.FOLLOWING = 4)] = "FOLLOWING"), (i[(i.CONTAINS = 8)] = "CONTAINS"), (i[(i.CONTAINED_BY = 16)] = "CONTAINED_BY"); | |
| var i; | |
| r(8866), ((i = {})[(i.DISCONNECTED = 1)] = "DISCONNECTED"), (i[(i.PRECEDING = 2)] = "PRECEDING"), (i[(i.FOLLOWING = 4)] = "FOLLOWING"), (i[(i.CONTAINS = 8)] = "CONTAINS"), (i[(i.CONTAINED_BY = 16)] = "CONTAINED_BY"); |
| s, | ||
| o = r(747); | ||
| ((n = a || (a = {}))[(n.XML = 0)] = "XML"), (n[(n.HTML = 1)] = "HTML"), ((i = s || (s = {}))[(i.UTF8 = 0)] = "UTF8"), (i[(i.ASCII = 1)] = "ASCII"), (i[(i.Extensive = 2)] = "Extensive"), (i[(i.Attribute = 3)] = "Attribute"), (i[(i.Text = 4)] = "Text"); |
Copilot
AI
Jan 30, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value assigned to a here is unused.
| o = r(747); | ||
| ((n = a || (a = {}))[(n.XML = 0)] = "XML"), (n[(n.HTML = 1)] = "HTML"), ((i = s || (s = {}))[(i.UTF8 = 0)] = "UTF8"), (i[(i.ASCII = 1)] = "ASCII"), (i[(i.Extensive = 2)] = "Extensive"), (i[(i.Attribute = 3)] = "Attribute"), (i[(i.Text = 4)] = "Text"); |
Copilot
AI
Jan 30, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value assigned to s here is unused.
| s, | |
| o = r(747); | |
| ((n = a || (a = {}))[(n.XML = 0)] = "XML"), (n[(n.HTML = 1)] = "HTML"), ((i = s || (s = {}))[(i.UTF8 = 0)] = "UTF8"), (i[(i.ASCII = 1)] = "ASCII"), (i[(i.Extensive = 2)] = "Extensive"), (i[(i.Attribute = 3)] = "Attribute"), (i[(i.Text = 4)] = "Text"); | |
| o = r(747); | |
| ((n = a || (a = {}))[(n.XML = 0)] = "XML"), (n[(n.HTML = 1)] = "HTML"), ((i = i || (i = {}))[(i.UTF8 = 0)] = "UTF8"), (i[(i.ASCII = 1)] = "ASCII"), (i[(i.Extensive = 2)] = "Extensive"), (i[(i.Attribute = 3)] = "Attribute"), (i[(i.Text = 4)] = "Text"); |
| (i = t), (a = !0); | ||
| break; | ||
| } | ||
| !a && t.length > i.length && (i = t); |
Copilot
AI
Jan 30, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This negation always evaluates to true.
Summary
Test plan
bun run typecheckpassesbun run checkpasses (biome)