Support for "Simulator device set"#25
Open
RobinDaugherty wants to merge 4 commits intoUrbanCompass:masterfrom
Open
Support for "Simulator device set"#25RobinDaugherty wants to merge 4 commits intoUrbanCompass:masterfrom
RobinDaugherty wants to merge 4 commits intoUrbanCompass:masterfrom
Conversation
|
This is what we are missing too unfortunately, is this repo still active? If yes, it would be amazing to merge this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to address #24.
Mussel client infers the device set based on the
HOMEenvironment variable, which contains a path to the application within the Simulator. If it contains the string "XCTestDevices", then we use the device set name "testing". However, this could be changed to specify the path of the device set instead of the magic name "testing" by truncating it.I changed the client to use a base class instead of protocol so that shared behavior can be written once. Identifying the current simulator ID and device set are in the base class. The base class implements the
serverRequest(task:options:)method, and layers in these two items.On the server, if a request includes the new option, it's used in the
simctlcommand line. I also changed this to fail early if the weakselfhas gone away, rather than return a success status.