Wait for server request to complete so UI test breakpoints work as expected#23
Open
RobinDaugherty wants to merge 1 commit intoUrbanCompass:masterfrom
Open
Conversation
to allow breakpoints to be set in the UI test directly after a Mussel request is issued.
indubala24
approved these changes
Feb 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem I experienced is:
MusselUniversalLinkTester.open(link)This is caused by the fact that
URLRequestdoes work in another queue once the task is resumed, and by setting a breakpoint directly after resuming the task, the other queue never performs the work. The fix is to have Mussel wait until theURLRequesttask completes before returning. I did this using aDispatchGroup.I also added some
debugPrintcalls so that when the request is complete, there's some evidence of it in the debug logs.