Various fixes for handling deactivated models#15
Open
koalahntr wants to merge 6 commits intoUltimaHoarder:mainfrom
Open
Various fixes for handling deactivated models#15koalahntr wants to merge 6 commits intoUltimaHoarder:mainfrom
koalahntr wants to merge 6 commits intoUltimaHoarder:mainfrom
Conversation
…t align due to APIs returning deactivated users
…"lastMessage" is missing from chat result
…ng from json_request results.
Author
|
Didn't realize the empty response was handled in a later version, these fixes were written for the latest stable version 1.1.4. |
Collaborator
|
Ah yeah, thanks for this. I haven't activated 2.0.X for the scraper yet due to compatibility issues |
…all, however, they are not scrapable. Without this, option_manager tries to dereference a NoneType and will hard error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some quirky behaviors from both API providers when models are deactivated, particularly when getting chats/messages.