Skip to content

Conversation

@edis-uipath
Copy link
Contributor

@edis-uipath edis-uipath commented Jan 28, 2026

Summary

This PR removes the test_extraction_tool_handles_missing_attachment_id test that is no longer needed after a breaking change in uipath-python.

Breaking Change

uipath-python PR: #1221 - feat: extend invoke process with attachments support

What Changed:
The Attachment.id field was changed from optional to required:

# Before
id: Optional[uuid.UUID] = Field(None, alias="ID")

# After  
id: uuid.UUID = Field(..., alias="ID")  # Now REQUIRED

Why the Test Was Removed

The test_extraction_tool_handles_missing_attachment_id test is no longer needed because:

  1. Breaking change makes scenario invalid: After PR #1221, Attachment.id is now a required field. The scenario of "missing attachment ID" is no longer a valid use case.

  2. Duplicates existing coverage: The test test_extraction_tool_downloads_attachment_and_calls_interrupt already covers the happy path with a valid attachment ID, providing sufficient coverage.

  3. Environment inconsistency: The test behaved differently between local and CI environments:

    • Locally: Raised ValidationError because ID field was missing
    • CI: Validation passed with id=None, then failed with TypeError during execution
  4. Reviewer feedback: The PR review noted that this test duplicates coverage with the existing test for the happy path.

Changes

  • Removed: test_extraction_tool_handles_missing_attachment_id test
  • Kept: test_extraction_tool_downloads_attachment_and_calls_interrupt (covers valid attachment with ID)

Impact

  • Tests: All 687 tests pass ✅
  • Coverage: No reduction in meaningful test coverage - the valid use case is still tested
  • CI Stability: Removes flaky test that behaved inconsistently across environments

Related

🤖 Generated with Claude Code

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the extraction tool test suite to align with the upstream uipath breaking change that makes Attachment.id required, unblocking the previously failing test.

Changes:

  • Update test_extraction_tool_handles_missing_attachment_id to include a valid UUID in the tool input.
  • Update the mock assertion to expect a UUID(...) key instead of None.
  • Adjust the test docstring to reflect the new input requirement.

@edis-uipath edis-uipath force-pushed the chore/fix-tests-attachment-guid branch 2 times, most recently from d14231a to 40e1d9d Compare January 28, 2026 15:18
@edis-uipath edis-uipath force-pushed the chore/fix-tests-attachment-guid branch from 40e1d9d to 4200164 Compare January 28, 2026 15:26
@edis-uipath edis-uipath merged commit fd41fa6 into main Jan 28, 2026
39 checks passed
@edis-uipath edis-uipath deleted the chore/fix-tests-attachment-guid branch January 28, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants