[issue-873] Templated Event Buffer#876
Merged
NicolasJPosey merged 7 commits intoSharedDevelopmentfrom Jan 30, 2026
Merged
Conversation
This involved moving the EventBuffer.cpp information into the header file and updating previous usages to use uint64_t type which was the old default. Also cleaned up redudent overrides and added getters and setters to the EventBuffer so that it's friendship with neuro classes could be removed.
NicolasJPosey
added
cleanup
refactor
NicolasJPosey
changed the title
stiber
requested changes
Aug 11, 2025
Contributor
stiber
left a comment
stiber
left a comment
There was a problem hiding this comment.
Minor stuff. Let me know if this is essential for this summer's release; otherwise, we will hold it back from SharedDevelopment until the CPU compilation hotfix gets merged into the release.
Contributor
Author
|
@stiber this PR is not essential for this summer's release. I can use the DoubleEventBuffer implementation until this makes it into SharedDevelopment then update the 911 GPU code to use the templated version once SharedDevelopment is merged in. |
Contributor
Author
|
@stiber I pulled SharedDevelopment into this branch and reran the unit/regression tests. Everything looks good and is passing. I had resolved the requested changes so I don't know why GitHub isn't just in a pending review state, but this PR is ready for your re-review. |
stiber
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #873 #870
Description
Checklist (Mandatory for new features)
Testing (Mandatory for all changes)
test-medium-connected.xmlPassedtest-large-long.xmlPassed