Remove reference to window to fix ssr error#79
Open
davidpdd wants to merge 1 commit intoTrendyol:masterfrom
Open
Remove reference to window to fix ssr error#79davidpdd wants to merge 1 commit intoTrendyol:masterfrom
davidpdd wants to merge 1 commit intoTrendyol:masterfrom
Conversation
necmicolak
approved these changes
May 17, 2022
|
I'm interested in this feature. Is there any discussion on merging fixes like this to help with SSR? |
yavuzkoca
approved these changes
Jan 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes window reference in scrolling-carousel that breaks server side rendering during build when the component is used in Gatsby.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).diff --git a/.github/workflows/PULL_REQUEST_TEMPLATE.md b/.github/workflows/PULL_REQUEST_TEMPLATE.md