Conversation
Contributor
|
cc @r3nat |
Contributor
|
@djanowski This doesn't work on OSX. I fixed it in #9 I had issues building on OpenVZ in Ubuntu 14.04, however the default image on GCE worked fine... so this should be good to go in #9 if you want to close this or pull in my OSX fixes. It doesn't matter to me. |
Open
Node 4.0 compatible and OSX build fixes
Contributor
There was a problem hiding this comment.
Will Nan::NewBuffer() internally call realloc() for the buffer? If not, it should be called before Nan::NewBuffer(), because now the code always returns bytesIn + 100 bytes (with result bytes stored in it).
Contributor
|
upd:
@r3nat @bobrik I don't know much about npm's versioning policy, so should we bump addon's major version (new code uses nan2, which is incompatible with previous versions)? |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.