Skip to content

feat: comment out unused endpoint_url handling in S3Client #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amindadgar merged 1 commit into from
May 21, 2025
Merged

feat: comment out unused endpoint_url handling in S3Client #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions hivemind_etl/storage/s3_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,16 @@ def __init__(self):
load_dotenv()

# Get AWS S3 environment variables
self.endpoint_url = os.getenv("AWS_ENDPOINT_URL")
# self.endpoint_url = os.getenv("AWS_ENDPOINT_URL")
self.access_key = os.getenv("AWS_ACCESS_KEY_ID")
self.secret_key = os.getenv("AWS_SECRET_ACCESS_KEY")
self.bucket_name = os.getenv("AWS_S3_BUCKET")
self.region = os.getenv("AWS_REGION")
self.secure = os.getenv("AWS_SECURE", "true").lower() == "true"

# Check each required variable and log if missing
missing_vars = []
if not self.endpoint_url:
missing_vars.append("AWS_ENDPOINT_URL")
# if not self.endpoint_url:
# missing_vars.append("AWS_ENDPOINT_URL")
if not self.access_key:
missing_vars.append("AWS_ACCESS_KEY_ID")
if not self.secret_key:
Expand All @@ -44,8 +43,7 @@ def __init__(self):
raise ValueError(error_msg)

logging.info(
f"Initializing S3 client with endpoint: {self.endpoint_url}, "
f"bucket: {self.bucket_name}, region: {self.region}, secure: {self.secure}"
f"Initializing S3 client with bucket: {self.bucket_name}, region: {self.region}"
)

# Configure S3 client
Expand All @@ -56,11 +54,10 @@ def __init__(self):

self.s3_client = boto3.client(
"s3",
endpoint_url=self.endpoint_url,
# endpoint_url=self.endpoint_url,
aws_access_key_id=self.access_key,
aws_secret_access_key=self.secret_key,
config=config,
verify=self.secure,
)

# Ensure bucket exists
Expand Down