Remove DisableDebuggerAttachment option

[DonnchaC]

DisableDebuggerAttachment was added in 839fc5a but it doesn't work when applied to an already running Tor (#80). This option can only be set before Tor is launched. I'm removing it for now as I don't see why it is needed when running the bwscanner.

Resolves #80.

[coveralls]

Coverage remained the same at 64.361% when pulling 0ec9bca on remove-disable-debugger into 839fc5a on develop.

[juga0]

According to this line https://github.com/TheTorProject/bwscanner/blob/develop/bwscanner/attacher.py#L174, getting first the tor state and then upgrading the configuration options should avoid the error Transition not allowed. So, it seems that getting first the tor state doesn't avoid the race condition.
Is there a way we could change the options before tor get launched?.
Also, why the error Transition not allowed would happen only with the option DisableDebuggerAttachment and not the others?.

I'm removing it for now as I don't see why it is needed when running the bwscanner.

According to @teor2345 #55 (comment), it was added because:

(Those last two are from chutney, see https://gitweb.torproject.org/chutney.git/tree/torrc_templates/common.i )

[ln5]

Also, why the error Transition not allowed would happen only with the option DisableDebuggerAttachment and not the others?.

Some options affect things which cannot be changed without a restart, see options_transition_allowed() [tor/src/or/config.c] for more options of that type.

[juga0]

I see, ok. Still i'll see if we can avoid the error by updating the options before tor gets launched.

[juga0]

Let's remove then the option for now, once #85 is merged we can see whether we should add back this option.