check bounds rather than generate exceptions

[bruce-lindsay]

This had a serious performance benefit. In my case (single select fetching 164 records) the catch block for ArgumentOutOfRangeException was hit 432 times. Using an explicit bounds check prevented these exceptions and was noticeably faster

[ThatRendle]

Thanks for this. I will pull and release patched build next time I'm on my
Windows machine.

Sent using CloudMagic [https://cloudmagic.com/k/d/mailapp?ct=pi&cv=6.0.64&pv=8.1.1]
On Fri, Aug 7, 2015 at 20:57, markrendle/Simple.Data
reply@reply.github.com
wrote:
This had a serious performance benefit. In my case (single select fetching 164
records) the catch block for ArgumentOutOfRangeException was hit 432 times.
Using an explicit bounds check prevented these exceptions and was noticeably
faster

---

YOU CAN VIEW, COMMENT ON, OR MERGE THIS PULL REQUEST ONLINE AT:
#373
[https://github.com//pull/373]

COMMIT SUMMARY

• check bounds rather than generate exceptions

FILE CHANGES

• M Simple.Data.Ado/OptimizedDictionary2.cs
  https://github.com/markrendle/Simple.Data/pull/373/files#diff-0

PATCH LINKS:

• https://github.com/markrendle/Simple.Data/pull/373.patch
  [https://github.com/check bounds rather than generate exceptions #373.patch]
• https://github.com/markrendle/Simple.Data/pull/373.diff
  [https://github.com/check bounds rather than generate exceptions #373.diff]

—
Reply to this email directly or view it on GitHub [https://github.com//pull/373] .[https://github.com/notifications/beacon/AAK4QgteyW0Y_nGiP6D1n5oNJC2y82lLks5olQUQgaJpZM4FnyRa.gif]

[bruce-lindsay]

Great, glad I could help. Do you know what commit SHA produced 0.19.0 nuget package? I'm currently dependent on that version but not sure what SHA to hotfix this against without introducing other changes. Thanks