Split endTransmission and requestFrom so function signaturess exactly…#27
Open
AxTheB wants to merge 1 commit intoTestato:masterfrom
Open
Split endTransmission and requestFrom so function signaturess exactly…#27AxTheB wants to merge 1 commit intoTestato:masterfrom
AxTheB wants to merge 1 commit intoTestato:masterfrom
Conversation
Collaborator
Author
|
Yes, you have to make them virtual, but you have to do it in Wire.h. Having this merged is just a step on my quest to get it working upstream (or at least having less libraries to patch when deploying my hardware) |
Owner
|
Arduino Teams decided they didn't want to set up Virtual the functions in Wire.h. It would still be useful match all functions with TwoWire API, but should be cheched if not only this two functions need modifications. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… match TwoWires, so it can be used in 3rd party libraries. (if/when Arduino makes beginTransmission, beginTransmission and requestFrom virtual)