Remove now dead code on OggOpusWriter#110
Open
AlexTMjugador wants to merge 1 commit intoTeamPyOgg:masterfrom
Open
Remove now dead code on OggOpusWriter#110AlexTMjugador wants to merge 1 commit intoTeamPyOgg:masterfrom
OggOpusWriter#110AlexTMjugador wants to merge 1 commit intoTeamPyOgg:masterfrom
Conversation
TeamPyOgg@d2a59e0 left the `_packet_valid` field unused, and always set to `False`. Generating an EOS packet and page is now done by the encoder as part of the `_write_to_oggopus` invocation, so there is no need for any new packet writing logic on `close()` anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
d2a59e0 left the
_packet_validfield unused, and always set toFalse. Generating an EOS packet and page is now done by the encoder as part of the_write_to_oggopusinvocation, so there is no need for any new packet writing logic onclose()anymore.