Draft
Conversation
github-actions
bot
requested review from
Gangsss,
Kimdongui,
KyungHyunLim and
jonhyuk0922
Kimdongui
added
feature
Kimdongui
reviewed
Jul 31, 2022
Kimdongui
reviewed
Jul 31, 2022
Member
Kimdongui
left a comment
Kimdongui
left a comment
There was a problem hiding this comment.
abstract_beverage.py general_beverage.py와 같이 두 파일로 따로 구현하는 방식은 어떨까요??
github-actions
bot
added
need-to-change-branch-name
and removed
feature
Kimdongui
added
feature
Collaborator
Author
다른 코드도 작업할 때도 몰아서 작업해서 이것도 몰아서 작업하긴 했는데 분리하는게 좋을까요? |
Member
네네! 아니면 분리하는 코드는 제가 한번 짜볼까요?? |
Collaborator
|
@Kimdongui 동현님 코드 짜신 후에 리뷰하겠습니다. |
KyungHyunLim
approved these changes
Aug 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes?
템플릿 패턴을 위한 코드 추가
Why we need?
템플릿 패턴 학습
Test?
template_test.py 를 통해 테스트
Checklist
Anything Else? (Optional)
테스트 코드를 pytest를 활용하는 형태로 변경