Skip to content

Conversation

@Kinbaum
Copy link

@Kinbaum Kinbaum commented Jan 17, 2026

🎯 Changes

This PR keeps the hotkey working globally, but prevents accidental toggles while typing in an editable field by guarding the createShortcut callback.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

@changeset-bot
Copy link

changeset-bot bot commented Jan 17, 2026

🦋 Changeset detected

Latest commit: 183ad57

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@tanstack/devtools Patch
@tanstack/preact-devtools Patch
@tanstack/react-devtools Patch
@tanstack/solid-devtools Patch
@tanstack/vue-devtools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Kinbaum
Copy link
Author

Kinbaum commented Jan 21, 2026

@AlemTuzlak Can I get your eyes on this?

@AlemTuzlak
Copy link
Collaborator

so where does this work exactly, not only contentEditable fields but inputs, textareas etc right?

@Kinbaum
Copy link
Author

Kinbaum commented Jan 21, 2026

@AlemTuzlak That’s correct. When I typed into those fields and pressed Shift+A as part of my sentence, DevTools opened instead of the character being entered. This update resolves the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants