Open
Conversation
This reverts commit 471e39d.
Collaborator
Author
|
not quite sure why atm the check passes on the PR (incorrect) but not on the commit (correct), but I suspect that review dog is filtering the errors on the PR because they don't stem from anything modified here, in that case this wouldn't be a problem (and indeed the desired behaviour) in normal use |
8 tasks
Computerdores
added
Type: CI
This was referenced Nov 26, 2025
8 tasks
Collaborator
Author
|
There are now PRs open for all remaining Pyright errors, once those are merged this PR should be mergable, save for any issues that show up in review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a pyright workflow using reviewdog (see #1061).
While this is intended to be merged once the code base is ready, in the mean-time I whipped this up to give us an idea were we are in the process of getting there.
PS: I didn't remove the mypy workflow, but it might make sense to put that into this PR as well.
Tasks Completed