[Docs] Export Grid data to CSV cookbook #325
Conversation
loic425
force-pushed
the
export-cookbook
branch
2 times, most recently
from
daa2019 to
19ed696
Compare
loic425
force-pushed
the
export-cookbook
branch
2 times, most recently
from
9fe3fa7 to
030b8a5
Compare
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace App\Shared\Infrastructure\Sylius\Resource; |
There was a problem hiding this comment.
I'm wondering if we use sth from RAD structure instead.
There was a problem hiding this comment.
Yes I would say RAD is better here, to remain consistent with the rest of the cookbooks parts (even the updated grid / entity here are just in App/Entity, App/Grid, etc and not confuse users as we already have the DDD cookbook later
There was a problem hiding this comment.
yep, you are right, done.
loic425
force-pushed
the
export-cookbook
branch
from
030b8a5 to
f17a9fe
Compare
app/Grid/BookGrid.php
Outdated
| ->addActionGroup( | ||
| MainActionGroup::create( | ||
| CreateAction::create(), | ||
| Action::create('export', 'export') |
There was a problem hiding this comment.
maybe use named params here?
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace App\Shared\Infrastructure\Sylius\Resource; |
There was a problem hiding this comment.
Yes I would say RAD is better here, to remain consistent with the rest of the cookbooks parts (even the updated grid / entity here are just in App/Entity, App/Grid, etc and not confuse users as we already have the DDD cookbook later
loic425
force-pushed
the
export-cookbook
branch
from
47bd3a8 to
4d79471
Compare
loic425
force-pushed
the
export-cookbook
branch
2 times, most recently
from
5172a75 to
5ea7c44
Compare
Co-authored-by: Estelle Gaits <74190794+stlgaits@users.noreply.github.com>
loic425
force-pushed
the
export-cookbook
branch
from
5ea7c44 to
a25e909
Compare
2 participants
No description provided.