Skip to content

Conversation

@OmrSi
Copy link
Member

@OmrSi OmrSi commented Jan 30, 2026

Hey, it's been a while. :)

I was working on a dfxp file and noticed that when I try to remove the top alignment from a line, it just returns when I open the file again.

Looking into the file, which is extracted from an online platform, I saw it had:

      <region xml:id="region.after.center" tts:direction="rtl" tts:displayAlign="after" tts:textAlign="center" tts:origin="10% 10%" tts:extent="80% 80%" />
      <region xml:id="region.before.center" tts:direction="rtl" tts:displayAlign="before" tts:textAlign="center" tts:origin="10% 10%" tts:extent="80% 80%" />

The old code says that yPos has to be more than 40, which is not always the case, as you can see.
Given that you also have extent, shouldn't this be how it works? That yPos + yExtent is higher than a certain threshold that makes the text in the bottom area?

niksedk added a commit to niksedk/subtitleedit-avalonia that referenced this pull request Jan 31, 2026
@niksedk niksedk merged commit 6a028a9 into SubtitleEdit:main Jan 31, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants