Try to fix bottom alignment not detected in some ttml 1.0 files #10178
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, it's been a while. :)
I was working on a dfxp file and noticed that when I try to remove the top alignment from a line, it just returns when I open the file again.
Looking into the file, which is extracted from an online platform, I saw it had:
The old code says that
yPoshas to be more than 40, which is not always the case, as you can see.Given that you also have
extent, shouldn't this be how it works? ThatyPos + yExtentis higher than a certain threshold that makes the text in the bottom area?