This repository was archived by the owner on Jun 27, 2022. It is now read-only.
Add linkify and replace Urls on page contents#42
Open
usmanatron wants to merge 2 commits intoSoftwire:masterfrom
Open
Add linkify and replace Urls on page contents#42usmanatron wants to merge 2 commits intoSoftwire:masterfrom
usmanatron wants to merge 2 commits intoSoftwire:masterfrom
Conversation
Member
Author
|
Note: one test failing, fixed in another PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added linkify. Wanted to use npm but nothing else is and it would have added a lot of extra work.
I also had to modify the script as it uses requirejs to get the regex ( #36 ); Ive inlined it for now.
When the RequireJS ticket is done we can fix all of this properly!
Test: Manual only. Id like to write a test but I think itd be better to sort out #39 first
Risk: Minimal? Ive checked it works and at worst it wont do anything to it
Doc: None relevant imo