Setup DistNeighborloader for graph store sampling #432
Conversation
kmontemayor2-sc
requested review from
mkolodner-sc,
nshah-sc,
svij-sc,
xgao4-sc,
yliu2-sc and
zfan3-sc
as code owners
|
/unit_test_py |
|
/integration_test |
|
/e2e_test |
GiGL Automation@ 24:08:24UTC : 🔄 |
GiGL Automation@ 24:08:29UTC : 🔄 @ 01:08:15UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 24:08:31UTC : 🔄 |
mkolodner-sc
left a comment
mkolodner-sc
left a comment
There was a problem hiding this comment.
Thanks Kyle! Left a round of comments
|
/unit_test_py |
|
/integration_test |
GiGL Automation@ 23:41:27UTC : 🔄 |
GiGL Automation@ 23:41:31UTC : 🔄 @ 24:53:37UTC : ✅ Workflow completed successfully. |
|
/e2e_test |
GiGL Automation@ 24:06:23UTC : 🔄 |
|
/e2e_test |
|
/unit_test_py |
|
/integration_test |
GiGL Automation@ 17:55:50UTC : 🔄 @ 19:13:17UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 17:55:55UTC : 🔄 @ 18:59:09UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 17:56:05UTC : 🔄 @ 18:59:57UTC : ✅ Workflow completed successfully. |
mkolodner-sc
left a comment
mkolodner-sc
left a comment
There was a problem hiding this comment.
Thanks Kyle! Generally LGTM to me
|
/unit_test_py |
|
/integration_test |
|
/e2e_test |
GiGL Automation@ 21:11:30UTC : 🔄 @ 22:19:48UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 21:11:36UTC : 🔄 @ 22:11:08UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 21:11:42UTC : 🔄 @ 22:33:42UTC : ✅ Workflow completed successfully. |
svij-sc
left a comment
svij-sc
left a comment
There was a problem hiding this comment.
Thanks for addressing everything
LGTM beyond this thread:
https://github.com/Snapchat/GiGL/pull/432/changes#r2687675025
|
I will approve to unblock, but lets revisit the dictionary consideration here before calling this complete. |
Ack, I expect this to be a part of scale testing. |
Scope of work done
Setting up distributed neighborloader for graph store (GS) mode.
In this change we:
RemoteDistDatasetas an input for the loaderlist[Tensor]as inputs for GS sampling.Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO