[stability] fix socket closing when peer leaves#556
Open
schlagmichdoch wants to merge 7 commits intoSnapDrop:masterfrom
Open
[stability] fix socket closing when peer leaves#556schlagmichdoch wants to merge 7 commits intoSnapDrop:masterfrom
schlagmichdoch wants to merge 7 commits intoSnapDrop:masterfrom
Conversation
dxlliv
added a commit
to dxlliv/snapshare
that referenced
this pull request
May 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error
Often the following error is logged:
(See: #555 #542 #532 #345 #258 #252 #249 #247 #233 #194 #24)
Cause
I discovered that sockets are not properly closed when a peer leaves and quickly rejoines
Fix
This PR fixes the closing of sockets:
_onPeerLeft(peerId): The propertypeer._peermust bepeer._conn.peer._channel.onclose = nullAdditionally this PR closes all p2p connections when the websocket connection is closed.
Stability
Together with #528, #537 and #531 this increases the stabilty a lot on my instance