Fix short address decoding (develop branch)#14
Open
k06a wants to merge 1 commit intoSmartPool:developfrom
Open
Fix short address decoding (develop branch)#14k06a wants to merge 1 commit intoSmartPool:developfrom
k06a wants to merge 1 commit intoSmartPool:developfrom
Conversation
Example addresses: ``` 0x0014F55A50b281EFD12294f0Cda821Bd8171e920 0x0000000000000000000000000000000000000000 ```
Collaborator
|
Hi, thanks for changing the branch. |
Author
|
@yaronvel no, you should support addresses shorter than 20 bytes, because it could contain first zero bytes for the probability reasons. Encoders could encode addresses as numbers and use for example 19 or 18 bytes for some addresses, this is an absolutely valid case for abstract RLP encoder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example addresses: