Integration branch SixTrackLib 0.7.0#137
Open
martinschwinzerl wants to merge 80 commits intoSixTrack:masterfrom
Open
Integration branch SixTrackLib 0.7.0#137martinschwinzerl wants to merge 80 commits intoSixTrack:masterfrom
martinschwinzerl wants to merge 80 commits intoSixTrack:masterfrom
Conversation
Due to a search & replace error, 'sixtrack::(anonymous)::st_size_t` is defined as an alias to `::st_size_t` which is not necessarily the same size as `unsigned long long`. This seems to cause the problems described in SixTrack#133
NOTE: cmake 3.11 introduces the FetchContent extension which is much better suited than
the currently used ExternalProject facility (or manually downloading stuff via git)
- uses FetchContent to download OpenCL C headers, OpenCL C++ headers or the OpenCL icd loader if needed - Adapts to the new OpenCL 3.x header structure
…nto feature/pr137_sixtracklib_070
…inzerl/sixtracklib into feature/pr137_sixtracklib_070
- Deprecate the "use legacy c++ header" -> this is now discovery based, the user should not have to use this setting. It is kept for the sake of compability
- simplifies the the detection of the headers in case they are downloaded -> this no longer yields random results depending on the order but always a predictible outcome, sorted by most desireable headers first - supports the "always downloads headers" option from Settings.cmake - verifies that the OpenCL ICD loaded can successfully be built
- Fixes copy & paste error in 10th and 11th factorial switch-case statement - Removes recursion which does not work ootb on OpenCL 1.2
- removes recursive limitations -> this fixes issues on OpenCL - provide a "binary" like implementation with minimal temporary / local storage requirements optimised for GPUs
…2011 based algorithm
- adds helper functions for 1D grids to get global and local ids and sizes - adds searching for largest elements in a (shared memory) array bound to wavefront / warps
- Decrease SIXTRL_CERRF_ALG680_MIN_POW_2H_N to 2.22507385850720e-307 which is one order of magnitude above the smallest possible 64 Bit double precision number. This reduces the chance of hitting the limit close to the boundaries between the compute regions - consequently, the SIXTRL_CERRF_ALG680_MIN_TWO_H_VALUE has to be decreased to allow for SIXTRL_CERRF_ALG680_MIN_TWO_H_VALUE ^ ( N_S0 + N_S1 ) to still be >= than SIXTRL_CERRF_ALG680_MIN_POW_2H_N
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features / Main Improvements:
example/cxx/track_fodo_opencl_cxxandexample/cxx/track_fodo_cuda_cxxto allow easier comparison of tracking performance with simpletrackNote:
The minimum required CMake version has been bumped to version 3.11. This is due to the use of the 'FetchContent` feature to streamline the retrieval of external dependencies.